Handle umlaute and non ascii chars in toSlug

digitallyinduced · Apr 13, 2022 · 62dfeee · 62dfeee
1 parent bc2b663
commit 62dfeee
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/IHP/NameSupport.hs b/IHP/NameSupport.hs
@@ -235,11 +235,16 @@ haskellKeywords = [ "_"
 -- "hallo-welt"
 toSlug :: Text -> Text
 toSlug text =
-    text
-    |> map (\char -> if Char.isAlphaNum char then char else ' ')
-    |> toLower
-    |> words
-    |> intercalate "-"
+        text
+        |> toLower
+        |> map replaceChar
+        |> words
+        |> intercalate "-"
+    where
+        replaceChar 'ä' = 'a'
+        replaceChar 'ö' = 'o'
+        replaceChar 'ü' = 'u'
+        replaceChar char = if Char.isAlphaNum char && Char.isAscii char then char else ' '
 
 
 -- | Transform a data-field name like @userName@  to a friendly human-readable name like @User name@

diff --git a/Test/NameSupportSpec.hs b/Test/NameSupportSpec.hs
@@ -111,3 +111,7 @@ tests = do
             it "should make a slug string from a string" do
                 toSlug "IHP Release: 21.08.2020 (v21082020)" `shouldBe` "ihp-release-21-08-2020-v21082020"
                 toSlug "Hallo! @ Welt" `shouldBe` "hallo-welt"
+
+            it "should deal with umlaute" do
+                toSlug "käuferpass" `shouldBe` "kauferpass"
+                toSlug "äöü" `shouldBe` "aou"