Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GITHUB_OUTPUT #188

Closed
stuartleeks opened this issue Dec 17, 2022 · 8 comments
Closed

Handle GITHUB_OUTPUT #188

stuartleeks opened this issue Dec 17, 2022 · 8 comments
Assignees

Comments

@stuartleeks
Copy link
Collaborator

stuartleeks commented Dec 17, 2022

GitHub actions are deprecating the previous set-output approach for setting outputs in favour of echoing to GITHUB_OUTPUT (link) as flagged by @stephenandary in #180.

When run inside a dev container, the GITHUB_OUTPUT location is not accessible (even if the environment variable is set).

Proposed approach to handling this:

  • mount the host's GITHUB_OUTPUT location to /mnt/github/output inside the dev container
  • set the GITHUB_OUTPUT environment variable in the container to /mnt/github/output

This could be done automatically so that this just works as expected for users of the CI action.

Additionally, this approach could be adopted for GITHUB_OUTPUT, GITHUB_STATE, GITHUB_ENV, GITHUB_STEP_SUMMARY, and GITHUB_PATH

@stuartleeks
Copy link
Collaborator Author

This would require an update to devcontainers/cli (link)

@andar1an
Copy link
Contributor

andar1an commented Dec 17, 2022

Can the CLI handle multiple mount points already? Asking based on language in the description here: devContainersSpecCLI.ts#L112

@stuartleeks
Copy link
Collaborator Author

Yes, you're right!

@andar1an
Copy link
Contributor

Thank goodness haha. I like when things require less work! 😆

@joseviccruz
Copy link

+1!
I really need this feature ASAP

@joseviccruz
Copy link

Hi everyone, any updates here?

@stuartleeks
Copy link
Collaborator Author

I believe that @stephenandary is planning to handle this in #219

@stuartleeks
Copy link
Collaborator Author

Closed by #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants