#123 Spell Info #126
Merged
#123 Spell Info #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge development
|
Will take a look at this next week. |
derikb
requested changes
Sep 10, 2023
src/components/AddSpellButton.js
Outdated
| this.cur_character.setSpells(spell, level); | ||
| }; | ||
|
|
||
| _handleAccordionClick (ev) { |
There was a problem hiding this comment.
Think this method is left over from a copy/paste and isn't used.
src/components/AddSpellButton.js
Outdated
| this.spellDialog.open(); | ||
| } | ||
|
|
||
| _handleAddNewSpell (ev) { |
There was a problem hiding this comment.
I don't think this is getting used either? Which also means you don't need the getCurrentCharacter call in the connectedCallback.
Remove unused code
derikb
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of updated spell content. Looking for your opinion before I add more.
I was thinking a similar component with editable fields would work for the added spells.