Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployctl deploy ignores the --prod option #353

Closed
ansipunk opened this issue Jan 15, 2025 · 6 comments · Fixed by #354
Closed

deployctl deploy ignores the --prod option #353

ansipunk opened this issue Jan 15, 2025 · 6 comments · Fixed by #354

Comments

@ansipunk
Copy link

After deploying with said command, upon visiting the Deno Deploy's dashboard, it can be seen that no deployment is set as a production environment. When visiting the production website, its responds with "404 - The requested deployment does not exist."

Users have to manually promote an environment to production through the dashboard. deployctl deployments redeploy --prod fails saying that the project does not have a production environment and preview environment's ID has to be manually set in order to actually promote.

@ansipunk
Copy link
Author

To make matters worse, deployctl deploy --prod demotes the last production deployment, but doesn't promote any new deployments.

@theTechGoose
Copy link

+1

@arnauorriols
Copy link
Member

The bug happens when using the flags --env-file or --env. Working on a fix now.

@arnauorriols
Copy link
Member

@ansipunk @theTechGoose Can you confirm you are using either of --env-file or --env flags? Check also the deno.json config file, they might be defined there.

@arnauorriols
Copy link
Member

@ansipunk @theTechGoose v1.13.1 is out. Please test it and let us know if the issue is fixed in your end.

@ansipunk
Copy link
Author

@arnauorriols yup, fixed now. I indeed was using --env-file, never tried without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants