fix: added service entry for sentinel port on headless pods #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
approved these changes
Dec 3, 2024
Racer159
pushed a commit
that referenced
this pull request
Dec 3, 2024
🤖 I have created a release *beep* *boop* --- ## [8.0.1-uds.2](v8.0.1-uds.1...v8.0.1-uds.2) (2024-12-03) ### Bug Fixes * added service entry for sentinel port on headless pods ([#56](#56)) ([2dcd8cc](2dcd8cc)) ### Miscellaneous * **deps:** update valkey package dependencies ([#38](#38)) ([f49beaf](f49beaf)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows sentinels to be listed individually and accessed that way by the client rather than being behind the service. GitLab didn't work when accessing via the service, but did work when hitting the nodes directly.
This has been tested in that it's the version of the package I deployed locally for testing the integration with GitLab.
Related Issue
defenseunicorns/uds-bundle-software-factory-nutanix#220
Type of change
Checklist before merging