Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oscal)!: oscalmodel interface implementation for component definitions #874

Merged
merged 11 commits into from
Jan 17, 2025
Merged

feat(oscal)!: oscalmodel interface implementation for component definitions #874

merged 11 commits into from
Jan 17, 2025

Conversation

meganwolf0
Copy link
Collaborator

@meganwolf0 meganwolf0 commented Jan 13, 2025 •
edited
Loading

Description

Implementation of the OSCALModel interface for a Component Definition. Additionally:

  • Updated implementation of component definition in generate
  • Added types constants for the models in complete-schema
  • Updated the ssp HandleExisting function as an error was noted with variable overwriting (+ added test)

Note Skipping function updates to compose/validate to use this interface. As those are probably wrapped more directly in the validation refactor, opting to defer updates to those issues.

Related Issue

Fixes #747

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@meganwolf0 meganwolf0 changed the title 747 oscalmodel interface implementation for component definitions feat!(oscal): OSCALModel interface implementation for component definitions Jan 13, 2025
@meganwolf0 meganwolf0 changed the title feat!(oscal): OSCALModel interface implementation for component definitions feat(oscal)!: OSCALModel interface implementation for component definitions Jan 13, 2025
@meganwolf0 meganwolf0 changed the title feat(oscal)!: OSCALModel interface implementation for component definitions feat(oscal)!: osaclmodel interface implementation for component definitions Jan 14, 2025
@meganwolf0 meganwolf0 changed the title feat(oscal)!: osaclmodel interface implementation for component definitions feat(oscal)!: oscalmodel interface implementation for component definitions Jan 14, 2025
@meganwolf0 meganwolf0 marked this pull request as ready for review January 14, 2025 14:20
@meganwolf0 meganwolf0 requested a review from a team as a code owner January 14, 2025 14:20
@meganwolf0 meganwolf0 marked this pull request as draft January 14, 2025 14:39
@meganwolf0 meganwolf0 marked this pull request as ready for review January 14, 2025 14:56
@meganwolf0 meganwolf0 marked this pull request as draft January 14, 2025 15:47
@meganwolf0 meganwolf0 marked this pull request as ready for review January 14, 2025 18:32
mildwonkey
mildwonkey previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I thought I submitted this yesterday!

I left some non-blocking nitpicks - you're free to ignore them (or address in a later PR, I know you have a few queued up)

src/pkg/common/oscal/component_test.go Show resolved Hide resolved
src/pkg/common/oscal/system-security-plan.go Show resolved Hide resolved
brandtkeller
brandtkeller previously approved these changes Jan 16, 2025
View reviewed changes
@meganwolf0 meganwolf0 dismissed stale reviews from brandtkeller and mildwonkey via 11a5e46 January 16, 2025 17:12
@meganwolf0 meganwolf0 merged commit cd77cdd into main Jan 17, 2025
10 checks passed
@meganwolf0 meganwolf0 deleted the 747-oscalmodel-interface-implementation-for-component-definitions branch January 17, 2025 19:14
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mildwonkey mildwonkey mildwonkey approved these changes

@brandtkeller brandtkeller brandtkeller left review comments

Assignees
No one assigned
Labels
None yet
Projects
Lula and Friends
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSCALModel interface implementation for Component Definitions
3 participants
@meganwolf0 @mildwonkey @brandtkeller