fix: workaround pterm.SetDefaultOutput until it is fixed upstream to fix the message.UseBuffer #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignasi Barrera <nacx@apache.org>
brandtkeller
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #824 upgraded pterm from
v0.12.79tov0.12.80, and that introduces the pterm bug pterm/pterm#701.That causes the default writer to not be properly honored by the different pterm printers, breaking the Lula's
message.UseBuffer.This PR provides a workaround to explicitly set the writers until the issue is fixed upstream.
Related Issue
Fixes #849
Relates to pterm/pterm#701
Type of change
Checklist before merging