-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generate): support for profile model and basic generation #694
Conversation
…e_model_generation
…e_model_generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably going to play with it more/give more thought to the OSCALModel interface, but just to kick back some thoughts as a starter
I know this isn't OSCAL Schema compliant but Lula functionality wise what do you think about a situation where you want to create a profile for IL4 using FedRAMP Moderate that would introduce the need to add the control AU-5(1) which isn't in the baseline so that control should come from the FedRAMP High Baseline. Im thinking command/functionality wise allowing multiple sources, have something like Reconcile what that would actually look like in OSCAL but a quick way to say give me all of FedRAMP Moderate and this control(s) from High. (Also don't think this blocks this PR, its more of a future request/thought) |
I was going to move it off to another issue but you gave me to motivation to support an I believe we can accomplish the scenario above with a few commands. Processing that will be another story and scope for another issue I will write. |
Trying to follow the train of thought in the thread, but would --all not be the default if include or exclude wasn't provided? I guess, what happens in no flag vs --all? |
Great point - that was a gap. Added a OneRequired for the flags to lean into explicit vs default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Are we going to create follow-on issues to reconcile the OSCALModel
interface across the other models we have?
Added issues as referenced a few hours ago |
Description
Adds initial support for the profile model with some very basic generation functionality to build upon.
Looking to implement an OSCAL model interface for two reasons:
There is a lot to unpack with support for a new model. Doing research and looking to document findings but ultimately believe the majority of complexity will be wrapped into processing of a profile for use with another model (either upstream in a catalog or downstream in a component/ssp).
Intent is to document and further decompose both profile issues as well as oscal model issues.
Related Issue
Fixes #67
Relates to #
Type of change
Checklist before merging