Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add updated_at to graphql query #5611

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

trfv
Copy link
Contributor

@trfv trfv commented Jul 13, 2021

Summary
fix #4436
add updated_at to graqhql query for pullRequest for editorial workflow card.
without this, moment(entry.get('updatedOn')) will always be Invalid Date.
cf)
/~https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-core/src/components/Workflow/WorkflowList.js#L208-L210
/~https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-backend-github/src/API.ts#L583

スクリーンショット 2021-07-13 15 39 47

Test plan
e2e test

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)

@trfv trfv requested a review from a team July 13, 2021 06:49
@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jul 13, 2021
@erezrokah
Copy link
Contributor

Thanks @trfv, I'm quite surprised this doesn't break our tests as we use pre-recorded data:
/~https://github.com/netlify/netlify-cms/blob/b94d5f6e7fe07a2816098b377b30a4ddd39c9520/cypress/fixtures/Github%20Backend%20Editorial%20Workflow%20-%20GraphQL%20API__can%20update%20workflow%20status%20from%20within%20the%20editor.json#L376

I'll verify those tests are behaving as they should before merging

@erezrokah erezrokah force-pushed the feat/add_updated_at_to_graphql_query branch from 919aaa8 to 4c18baf Compare July 15, 2021 18:14
@erezrokah
Copy link
Contributor

@trfv, see /~https://github.com/netlify/netlify-cms/pull/5616/files#diff-968c14cc900beced6e94a6fab4c827e18c6c39f9acade8b34fdfdfac2da83fa7R54.

I believe the tests should fail now until we update the relevant snapshots.

@trfv
Copy link
Contributor Author

trfv commented Jul 16, 2021

@erezrokah
I updated the relevant e2e tests. please check again 🙏 .

@erezrokah erezrokah merged commit 8989550 into decaporg:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github GraphQL API is missing editorial workflow timeStamp
2 participants