Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt to save unsaved changes on browser close #286

Closed
erquhart opened this issue Mar 16, 2017 · 2 comments
Closed

Prompt to save unsaved changes on browser close #286

erquhart opened this issue Mar 16, 2017 · 2 comments
Assignees
@Benaiah
Labels
good first issue
Milestone
1.0.0

Comments

@erquhart
Copy link
Contributor

#249 provided a prompt to save unsaved changes when navigating browser history or cancelling from the UI, but the prompt does not occur if the user attempts to close the browser tab/window.

Requirements

  • If a user closes the browser tab/window, they should be prompted and allowed to cancel the action
@rolfea
Copy link

rolfea commented Jul 1, 2017

Hi there, @erquhart ! I'd be happy to work on this.

@erquhart
Copy link
Contributor Author

erquhart commented Jul 2, 2017

@rolfea great! 🍻 Feel free to check the pull request I mentioned above as prior art, and reach out on Gitter if you have any questions along the way.

@rolfea rolfea mentioned this issue Jul 12, 2017
Closed
@erquhart erquhart added this to the 1.0.0 milestone Sep 8, 2017
@Benaiah Benaiah self-assigned this Oct 27, 2017
@Benaiah Benaiah mentioned this issue Nov 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Benaiah Benaiah

Labels
good first issue
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@Benaiah @erquhart @rolfea