Escape backslashes in queries passed to UNLOAD #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -182,10 +182,10 @@ class RedshiftSourceSuite | |||
| |UNLOAD \('SELECT "testbyte", "testbool" FROM | |||
| | \(select testbyte, testbool | |||
| | from test_table | |||
| | where teststring = \\'Unicode\\'\\'s樂趣\\'\) '\) | |||
| | where teststring = \\'\\\\\\\\Unicode\\'\\'s樂趣\\'\) '\) | |||
There was a problem hiding this comment.
Note that in this unit test this line is a regex matching expected output, hence the extra level of backslash escaping.
Current coverage is 89.95%@@ master #228 diff @@
==========================================
Files 13 13
Lines 697 697
Methods 611 611
Messages 0 0
Branches 86 86
==========================================
+ Hits 626 627 +1
+ Misses 71 70 -1
Partials 0 0
|
|
Going to merge this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to escape backslashes that appear in the query passed to the
UNLOADcommand. This patch adds a regression test plus additional backslash escaping. Fixes #215.