Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

fix: protocol version is validated only for buffers #344

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Sep 8, 2021

Issue being fixed or feature implemented

In the current implementation, the protocol version is validated only during the Buffer decode process. When Buffer is decoded to raw object, outdated checks from JSON schema are applied.

What was done?

  • Remove JSON Schema validation rules for protocol version
  • Move protocol version validation from the decodeProtocolEntity function to basic validation functions

How Has This Been Tested?

With tests

Breaking Changes

Already described in #217

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.21.0 milestone Sep 8, 2021
Copy link
Contributor

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shumkov shumkov merged commit b83fe63 into v0.21-dev Sep 8, 2021
@shumkov shumkov deleted the set-protocol-version-1 branch September 8, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants