This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
fix: protocol version is validated only for buffers #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In the current implementation, the protocol version is validated only during the Buffer decode process. When Buffer is decoded to raw object, outdated checks from JSON schema are applied.
What was done?
decodeProtocolEntity
function to basic validation functionsHow Has This Been Tested?
With tests
Breaking Changes
Already described in #217
Checklist:
For repository code-owners and collaborators only