Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

feat: add protocolVersion option to DPP class #329

Merged
merged 8 commits into from
Jul 30, 2021
Merged

feat: add protocolVersion option to DPP class #329

merged 8 commits into from
Jul 30, 2021

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Jul 29, 2021

Issue being fixed or feature implemented

Adding an ability to pass external protocolVersion as an option

What was done?

  • added protocolVersion
  • added setter for it

How Has This Been Tested?

Unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.21.0 milestone Jul 29, 2021
@jawid-h jawid-h requested review from shumkov and antouhou July 29, 2021 08:56
shumkov
shumkov suggested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use protocol version from a DPP instance to create data in factories.

shumkov
shumkov suggested changes Jul 30, 2021
View reviewed changes
@jawid-h jawid-h requested a review from shumkov July 30, 2021 12:12
@shumkov shumkov changed the title feat: add protocolVersion option to main class feat: add protocolVersion option to DPP class Jul 30, 2021
shumkov
shumkov approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jawid-h jawid-h merged commit 4137708 into v0.21-dev Jul 30, 2021
@jawid-h jawid-h deleted the feat/protocol-version branch July 30, 2021 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov