Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementers section missing on RestorableValue. #2290

Closed
Hixie opened this issue Aug 10, 2020 · 3 comments · Fixed by #2358
Closed

Implementers section missing on RestorableValue. #2290

Hixie opened this issue Aug 10, 2020 · 3 comments · Fixed by #2358
Assignees

Comments

@Hixie
Copy link
Contributor

Hixie commented Aug 10, 2020

https://master-api.flutter.dev/flutter/widgets/RestorableInt-class.html says:

Inheritance
Object > ChangeNotifier > RestorableProperty<int> > RestorableValue<int> > RestorableNum<int> > RestorableInt

Click on RestorableNum, you get https://master-api.flutter.dev/flutter/widgets/RestorableNum-class.html:

Inheritance
Object > ChangeNotifier > RestorableProperty<T> > RestorableValue<T> > RestorableNum
Implementers
RestorableDouble, RestorableInt

Click on RestorableValue, you get https://master-api.flutter.dev/flutter/widgets/RestorableValue-class.html:

Inheritance
Object > ChangeNotifier > RestorableProperty<T> > RestorableValue

...with no "Implementers" section!

@Hixie
Copy link
Contributor Author

Hixie commented Aug 10, 2020

Oh, it's probably because there's a private class between RestorableValue and RestorableNum in the inheritance hierarchy.

@srawlins srawlins self-assigned this Sep 5, 2020
@srawlins
Copy link
Member

srawlins commented Sep 5, 2020

I think the solution is to treat any intermediate private classes as invisible "proxies", and continue to the public ones.

So if

  • A implements B, and
  • C implements _D implements B, and
  • E implements _F implements _G implements B,

then the page for B should list, as implementors, A (as it would today), C (skipping over _D), and E (skipping over _F and _G). Classes which implement A, C, and E are not shown (it is only a list of immediate implementors), but the links are there to follow.

@srawlins
Copy link
Member

f5985ce seems to have exacerbated this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants