-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(header-finalizer): support multiple headers with same name #2244
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
- Coverage 90.51% 90.45% -0.07%
==========================================
Files 279 279
Lines 12246 12251 +5
==========================================
- Hits 11085 11082 -3
- Misses 916 921 +5
- Partials 245 248 +3 ☔ View full report in Codecov by Sentry. |
Thank you @aslafy-z very much for the PR. As you can see above, I added some comments related to styling. |
I'll merge it as soon as the 0.15.8 is released and merged into the main branch. Otherwise this feature will be affected by #2237. |
@dadrus Thanks for taking a look! I think the styling comments might not have been submitted. Could you double-check? |
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
@dadrus I applied the requested changes and rebased on main. |
Related issue(s)
Closes #2206
Checklist
Description
This PR introduces support for multiple headers with the same name by allowing newline-separated values in the
header
finalizer. The values are split and added as individual headers, ensuring compatibility with applications that rely on this behavior.