Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header-finalizer): support multiple headers with same name #2244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Feb 27, 2025

Related issue(s)

Closes #2206

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.
  • I have updated the documentation.

Description

This PR introduces support for multiple headers with the same name by allowing newline-separated values in the header finalizer. The values are split and added as individual headers, ensuring compatibility with applications that rely on this behavior.

@aslafy-z aslafy-z changed the title feat(header-finalizer): support multiple dynamic headers with identical names feat(header-finalizer): support multiple headers with same name Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (de735f4) to head (899695c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
- Coverage   90.51%   90.45%   -0.07%     
==========================================
  Files         279      279              
  Lines       12246    12251       +5     
==========================================
- Hits        11085    11082       -3     
- Misses        916      921       +5     
- Partials      245      248       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aslafy-z aslafy-z marked this pull request as ready for review February 27, 2025 16:56
@dadrus
Copy link
Owner

dadrus commented Feb 28, 2025

Thank you @aslafy-z very much for the PR. As you can see above, I added some comments related to styling.

@dadrus
Copy link
Owner

dadrus commented Feb 28, 2025

I'll merge it as soon as the 0.15.8 is released and merged into the main branch. Otherwise this feature will be affected by #2237.

@aslafy-z
Copy link
Contributor Author

@dadrus Thanks for taking a look! I think the styling comments might not have been submitted. Could you double-check?

Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
@aslafy-z
Copy link
Contributor Author

@dadrus I applied the requested changes and rebased on main.

@aslafy-z aslafy-z requested a review from dadrus February 28, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header finalizer handling for multiple headers with the same name
2 participants