Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not shorten command message text with ellipsis #29023

Closed
jennifer-shehane opened this issue Feb 27, 2024 · 1 comment · Fixed by #29032
Closed

Do not shorten command message text with ellipsis #29023

jennifer-shehane opened this issue Feb 27, 2024 · 1 comment · Fixed by #29032
Labels
type: user experience Improvements needed for UX

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Feb 27, 2024

Current behavior

Currently, command messages will be truncated and shown with ellipsis when they reach a certain size. Example below with fake data is how it's shown.

Screenshot 2024-02-27 at 3 11 11 PM

The code doing this is here: /~https://github.com/cypress-io/cypress/blob/develop/packages/reporter/src/commands/commands.scss#L179

This is not so problematic when running cypress open, but this is problematic in Test Replay (which uses the same styles from our reporter). There is not console logging support to view the entire URL, so this information is lost.

Desired behavior

I want to be able to inspect the entire URL. We should not be truncating the command message text with ellipsis.

Test code to reproduce

Visit some URL with long text:

it('long URL', () => {
  cy.visit('https://cloud.cypress.io/projects/ypt4pf/analytics/top-failures?att=1&branches=%5B%7B%22value%22%3A%22develop%22%2C%22label%22%3A%22develop%22%7D%5D&browsers=%5B%5D&chartRangeMostCommonErrors=%5B%5D&chartRangeSlowestTests=%5B%5D&chartRangeTopFailures=%5B%5D&committers=%5B%7B%22label%22%3A%22Jennifer%20Shehane%22%2C%22suggested%22%3Afalse%2C%22labelProperties%22%3A%7B%22avatar%22%3A%22https%3A%2F%2Fs.gravatar.com%2Favatar%2F32df9b63f82b88207d6902273b23a9e4%3Fsize%3D13%26default%3Dmm%22%7D%2C%22value%22%3A%22jennifer%40cypress.io%22%7D%5D&cypressVersions=%5B%5D&flaky=%5B%7B%22label%22%3A%22Flaky%22%2C%22value%22%3Atrue%7D%5D&operatingSystems=%5B%7B%22label%22%3A%22Linux%20Debian%20-%2010.5%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22linux%22%7D%2C%22value%22%3A%22Linux%20Debian%20-%2010.5%22%7D%2C%7B%22label%22%3A%22Linux%20Debian%20-%2011.4%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22linux%22%7D%2C%22value%22%3A%22Linux%20Debian%20-%2011.4%22%7D%2C%7B%22label%22%3A%22Linux%20Debian%20-%2010.1%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22linux%22%7D%2C%22value%22%3A%22Linux%20Debian%20-%2010.1%22%7D%2C%7B%22label%22%3A%22Windows%2010.0.17763%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22win32%22%7D%2C%22value%22%3A%22Windows%2010.0.17763%22%7D%2C%7B%22label%22%3A%22Linux%20Debian%20-%2010.9%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22linux%22%7D%2C%22value%22%3A%22Linux%20Debian%20-%2010.9%22%7D%2C%7B%22label%22%3A%22Linux%20Ubuntu%20-%20%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22linux%22%7D%2C%22value%22%3A%22Linux%20Ubuntu%20-%20%22%7D%2C%7B%22label%22%3A%22Mac%2021.6.0%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22darwin%22%7D%2C%22value%22%3A%22Mac%2021.6.0%22%7D%2C%7B%22label%22%3A%22Mac%2022.4.0%22%2C%22labelProperties%22%3A%7B%22unformattedName%22%3A%22darwin%22%7D%2C%22value%22%3A%22Mac%2022.4.0%22%7D%5D&replayTestId=4b3ef969-6787-48b5-8f01-823de1f18456&runGroups=%5B%7B%22label%22%3A%222x-desktop-gui%22%2C%22suggested%22%3Afalse%2C%22value%22%3A%222x-desktop-gui%22%7D%2C%7B%22label%22%3A%225x-driver-chrome%22%2C%22suggested%22%3Afalse%2C%22value%22%3A%225x-driver-chrome%22%7D%2C%7B%22label%22%3A%225x-driver-chrome%3Abeta%22%2C%22suggested%22%3Afalse%2C%22value%22%3A%225x-driver-chrome%3Abeta%22%7D%2C%7B%22label%22%3A%225x-driver-chrome%3Abeta-experimentalSessionAndOrigin%22%2C%22suggested%22%3Afalse%2C%22value%22%3A%225x-driver-chrome%3Abeta-experimentalSessionAndOrigin%22%7D%5D&specFiles=%5B%7B%22label%22%3A%22runner%2Freporter.hooks.cy.ts%22%2C%22suggested%22%3Afalse%2C%22value%22%3A%22a3a45973-dfbc-a6f9-d342-4d58adde3224%22%7D%5D&status=%5B%7B%22label%22%3A%22Passed%22%2C%22value%22%3A%22PASSED%22%7D%2C%7B%22label%22%3A%22Failed%22%2C%22value%22%3A%22FAILED%22%7D%5D&tags=%5B%5D&tagsMatch=ANY&timeInterval=WEEK&timeRange=%7B%22startDate%22%3A%222024-01-28%22%2C%22endDate%22%3A%222024-02-27%22%7D&ts=1708725034416.3328&viewBy=TEST_CASE')
})

9.x was even worse.

Screenshot 2024-02-27 at 4 43 01 PM

This was introduced in 10.10.0 by this PR: #23995

Cypress Version

13.6.6

Node version

s

Operating System

Mac

Debug Logs

No response

Other

No response

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 13, 2024

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: user experience Improvements needed for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant