feat: swap websocket transport with cdp add binding/evaluate #27592
Conversation
4 flaky tests on run #50510 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property is `0` |
Test Replay
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
| // @ts-ignore | ||
| import * as engineParser from 'engine.io-parser' | ||
|
|
||
| export const encode = (data: any, namespace: string): Promise<string> => { |
There was a problem hiding this comment.
Add some error handling
There was a problem hiding this comment.
Are you planning to add error handling each of the places that encode and decode are used?
There was a problem hiding this comment.
Yeah I was trying to think through that. I'm not sure what else we can do other than log. I'll push that for now, but I may chat with @brian-mann to see if he has additional thoughts
There was a problem hiding this comment.
There was a problem hiding this comment.
Spoke with @brian-mann offline. We're going to let these bubble as they would be errors that are unrecoverable.
…com/cypress-io/cypress into ryanm/feat/swap-websockets-with-cdp
…com/cypress-io/cypress into ryanm/feat/swap-websockets-with-cdp
jennifer-shehane
requested review from
chrisbreiding
and removed request for
mschile
…e crashed, indicate we're continuing running the next spec
this was preventing crashed tabs from being closed when moving to the next spec
…com/cypress-io/cypress into ryanm/feat/swap-websockets-with-cdp
…ess and appears to be invalid
…com/cypress-io/cypress into ryanm/feat/swap-websockets-with-cdp
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This PR:
Steps to test
This can be tested by just running Cypress to ensure that things worked as previously
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?