Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto discover window.Store and lock to electron 8.3.1 #47

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

Zzombiee2361
Copy link
Collaborator

@Zzombiee2361 Zzombiee2361 commented Jun 18, 2020

Sometimes window.Store returns undefined. This obviously problematic since it would make many tray icon's feature useless. With this pull request WALC will now attempt to extract it from window.webpackJsonp.

Edit:
Due to electron/electron#23674 tray click event no longer executed and opens context menu instead. This affects electron 8.3.2 and locking electron to version 8.3.1 fixes this issue.

@Zzombiee2361 Zzombiee2361 changed the title Auto discover window.Store Auto discover window.Store and lock to electron 8.3.1 Jun 19, 2020
It will now only attempt to extract window.Store
when splash screen is gone
@Zzombiee2361
Copy link
Collaborator Author

@cstayyab bump! When will you merge this and release an update?

@cstayyab
Copy link
Collaborator

cstayyab commented Jun 26, 2020

I am merging this pull request. @Zzombiee2361 Can you test overall functionality from 'master' branch and then tell me so I can release the update?

@cstayyab cstayyab merged commit f91f910 into WAClient:master Jun 26, 2020
@cstayyab cstayyab linked an issue Jun 26, 2020 that may be closed by this pull request
@bkmo
Copy link

bkmo commented Jun 26, 2020

I have just built from master and the first thing I notice is the dark mode toggle is not doing anything. I have not received any messages to test the icon status. Edit: Received 2 messages and no change to tray icon. Did get a notification sound and onscreen notification.

@Zzombiee2361
Copy link
Collaborator Author

@cstayyab I'll test it tomorrow

@bkmo try reloading the page, if the problem still exists can you screenshot the output of window.Store from devtool's console?

@bkmo
Copy link

bkmo commented Jun 26, 2020 via email

@Zzombiee2361
Copy link
Collaborator Author

Huh, that's weird. Are you sure you pulled everything including changes in this pull request?

@bkmo
Copy link

bkmo commented Jun 26, 2020 via email

@bkmo
Copy link

bkmo commented Jun 26, 2020

I am on version 14.4.0 of NodeJS. Is this a problem?
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.

@Zzombiee2361
Copy link
Collaborator Author

@cstayyab I have tested and everything related to my changes are working. Although botClient on main process returns undefined, this will cause Archive All Chats and Mark All As Read not working. You might wanna update WhatsBot folder from the original repository.

@bkmo There's no problem with your npm packages, I think your repo is simply out of date. Run git pull on WALC folder to update it.

@bkmo
Copy link

bkmo commented Jun 27, 2020

Thanks...I think I can wait for the next release.
I am doing a git clone, then moving to WALC and doing a git pull and it is up to date. Still after npm install, and npm start I get no dark theme or tray icon notification.

@Zzombiee2361
Copy link
Collaborator Author

@cstayyab bump! When is it going to release?

@cstayyab
Copy link
Collaborator

cstayyab commented Jul 2, 2020 via email

@Zzombiee2361
Copy link
Collaborator Author

Nice, I'll be waiting for it!

@cstayyab
Copy link
Collaborator

cstayyab commented Jul 2, 2020

Nice, I'll be waiting for it!

Hey man, found a few more problems in the updated version. Can't release before fixing that. May be tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Tray icon does not show new messages
3 participants