-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto discover window.Store and lock to electron 8.3.1 #47
Conversation
It will now only attempt to extract window.Store when splash screen is gone
@cstayyab bump! When will you merge this and release an update? |
I am merging this pull request. @Zzombiee2361 Can you test overall functionality from 'master' branch and then tell me so I can release the update? |
I have just built from master and the first thing I notice is the dark mode toggle is not doing anything. I have not received any messages to test the icon status. Edit: Received 2 messages and no change to tray icon. Did get a notification sound and onscreen notification. |
At the console prompt just enter "window.Store" ?
If so I get > window.Store
< undefined
…On Fri, Jun 26, 2020 at 9:21 AM Daffa Mumtaz ***@***.***> wrote:
@cstayyab </~https://github.com/cstayyab> I'll test it tomorrow
@bkmo </~https://github.com/bkmo> try reloading the page, if the problem
still exists can you screenshot the output of window.Store from devtool's
console?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>, or
unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AAF5ZHJDNEKFWVRULYI4UCLRYS4JBANCNFSM4OBSGMEQ>
.
|
Huh, that's weird. Are you sure you pulled everything including changes in this pull request? |
I did a git clone like in the readme
# clone the repo
git clone /~https://github.com/cstayyab/WALC.git
#Move to WALC directory
cd WALC
# install dependencies
npm install
# start the app
npm start
…On Fri, Jun 26, 2020 at 9:38 AM Daffa Mumtaz ***@***.***> wrote:
Huh, that's weird. Are you sure you pulled everything including changes in
this pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>, or
unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AAF5ZHJMJBOSBGXYVE6HMADRYS6INANCNFSM4OBSGMEQ>
.
|
I am on version 14.4.0 of NodeJS. Is this a problem? |
@cstayyab I have tested and everything related to my changes are working. Although @bkmo There's no problem with your npm packages, I think your repo is simply out of date. Run |
Thanks...I think I can wait for the next release. |
@cstayyab bump! When is it going to release? |
I will release it today, for sure !!
…On Thu, Jul 2, 2020 at 9:15 AM Daffa Mumtaz ***@***.***> wrote:
@cstayyab </~https://github.com/cstayyab> bump! When is it going to release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>, or
unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AHB2JEVTHH7UIL5KW7PWEV3RZQCVRANCNFSM4OBSGMEQ>
.
|
Nice, I'll be waiting for it! |
Hey man, found a few more problems in the updated version. Can't release before fixing that. May be tomorrow. |
Sometimes
window.Store
returns undefined. This obviously problematic since it would make many tray icon's feature useless. With this pull request WALC will now attempt to extract it fromwindow.webpackJsonp
.Edit:
Due to electron/electron#23674 tray click event no longer executed and opens context menu instead. This affects electron 8.3.2 and locking electron to version 8.3.1 fixes this issue.