Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rely on status updates and consume DesiredStateChanged predicate #176

Closed
turkenh opened this issue Mar 20, 2023 · 0 comments · Fixed by #231
Closed

Do not rely on status updates and consume DesiredStateChanged predicate #176

turkenh opened this issue Mar 20, 2023 · 0 comments · Fixed by #231
Labels
enhancement New feature or request

Comments

@turkenh
Copy link
Member

turkenh commented Mar 20, 2023

What problem are you facing?

With crossplane/crossplane-runtime#372, we have introduced a DesiredStateChanged to the xp runtime, which would filter out status update events.

However, upjet relies on status updates to re-queue after an async operation is completed. We need to fix it and consume DesiredStateChanged predicate.

How could Upjet help solve your problem?

Do not rely on status updates and consume DesiredStateChanged predicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Requeue the reconcile request on async update error ulucinar/upbound-upjet
1 participant
@turkenh