s3 bucket policy to v1alpha2

[krishchow]

Description of your changes

Fixes #374

I have:

• Read and followed Crossplane's [contribution process].
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Additional unit tests, and manual testing
[contribution process]: https://git.io/fj2m9

[krishchow]

The main reason I opened this draft PR early on in the process is to get feedback from the community. There are a few points of discussion I want to try and get a dialog on:

• I haven't changed the API group yet, because I am not sure if this qualifies as ready for v1beta1, or if it should be v1alpha2.
• Currently, I am templating the Resource field of the bucket policy with the ARN prefix, and then the rest of the bucket path. This isn't required, but it is more of a QOL feature, since it is generally less to write for users, and I have not been able to find a case where the resource is not an S3 bucket. However, I can see a clear reason for removing it, since it may be unclear to new users of the provider-aws since the input syntax is different from a regular AWS s3 bucket policy.

[krishchow]

• Ended up moving the bucket to v1alpha2 to stay on the safe side.
• I am no longer templating the resource ARN, I don't think it was necessary, and it could make it harder to understand the bucket policy initially.

[hasheddan]

@krishchow apologies for the delay in review here! This looks pretty good to me :) It looks like the main change is that we reference the IAM user directly instead of extracting it from the Bucket, are there any other major differences here?

@muvaf could you take a peek at this as well?

[krishchow]

@hasheddan that's one of the main changes yes :). Instead of referencing a single IAMUser for the entire policy, each statement can refer to an IAMUser.

I have also added support for a few other identity types supported by the bucket policy, also the other big thing support for Condition in the policy. This was one key feature that wasn't previously supported.

[muvaf]

Sorry for the delayed review. There are a few things to address and I think it's the right call to make it v1alpha2 for now. Thanks @krishchow !

[muvaf]

I think some of the parameters are immutable like BucketName

[muvaf]

thanks @krishchow !

[muvaf]

@krishchow could you resolve the conflict so that we can merge it?

[krishchow]

@muvaf Rebased and fixed all the conflicts