Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifconfig.me as fallback for automatic WAN_IP determination #96

Merged
merged 1 commit into from
May 31, 2021

Conversation

seijikun
Copy link
Contributor

Unfortunately,

dig +short myip.opendns.com @resolver1.opendns.com

does not return anything when routing the traffic through certain VPN providers.
Especially using a VPN is a situation where automatic determination of $WAN_IP is important, though.

How about adding a fallback by using curl ifconfig.me?

Add curl ifconfig.me as fallback for the existing dig to myip.opendns.com, because the latter does not return anything for certain VPN providers.
@seijikun seijikun requested a review from crazy-max as a code owner May 25, 2021 20:56
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 4c9446e into crazy-max:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants