Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a note in traefik.sample.toml #4757

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Adds a note in traefik.sample.toml #4757

merged 1 commit into from
Apr 12, 2019

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 12, 2019

What does this PR do?

Adds a note in traefik.sample.toml

Motivation

Be clear that the sample is for v2 and add a reference the the v1 sample.

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Apr 12, 2019
jbdoumenjou
jbdoumenjou approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dtomcej
dtomcej approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit b9f8265 into traefik:v2.0 Apr 12, 2019
@ldez ldez deleted the feature/doc-sample branch April 12, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@dduportal dduportal dduportal approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @jbdoumenjou @dduportal @dtomcej @traefiker