Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TCP in the marathon provider #4728

Merged
merged 8 commits into from
Apr 15, 2019
Merged

Conversation

juliens
Copy link
Member

@juliens juliens commented Apr 5, 2019

What does this PR do?

This PR adds the TCP support on the provider Marathon

Motivation

Be able to do TCP proxy with the marathon provider

More

  • Added/updated tests

Additional Notes

Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we tweak the documentation accordingly?

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said before, shouldn't we include the documentation for the feature?

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the documentation to make a real case test.

@mpl
Copy link
Collaborator

mpl commented Apr 12, 2019

@geraldcroes doc done.

docs/content/providers/marathon.md Outdated Show resolved Hide resolved
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d1d2611 into traefik:v2.0 Apr 15, 2019
@juliens juliens deleted the marathon-tcp branch September 6, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants