-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle TCP in the marathon provider #4728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we tweak the documentation accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said before, shouldn't we include the documentation for the feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the documentation to make a real case test.
@geraldcroes doc done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Mathieu Lonjaret <mathieu.lonjaret@gmail.com>
Co-Authored-By: juliens <julien.salleyron@gmail.com>
What does this PR do?
This PR adds the TCP support on the provider Marathon
Motivation
Be able to do TCP proxy with the marathon provider
More
Additional Notes
Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com