Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance acme page. #4611

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Enhance acme page. #4611

merged 4 commits into from
Mar 18, 2019

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 17, 2019 •
edited
Loading

What does this PR do?

Enhance acme page.

Motivation

Have a good documentation

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the next milestone Mar 17, 2019
@ldez ldez force-pushed the refactor/acme-doc branch from 83af3cc to a29d21a Compare March 17, 2019 18:37
jbdoumenjou
jbdoumenjou approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

@traefiker traefiker merged commit 9908137 into traefik:master Mar 18, 2019
@ldez ldez deleted the refactor/acme-doc branch March 18, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @geraldcroes @jbdoumenjou @traefiker