Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds update ingress status #4603

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Adds update ingress status #4603

merged 2 commits into from
Mar 18, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Mar 15, 2019

What does this PR do?

Re add the update ingress status in the kubernetes provider.

Motivation

To add the address of the ingress controller when we kubectl describe the ingress.

@ldez ldez added this to the next milestone Mar 15, 2019
ldez
ldez approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

@traefiker traefiker merged commit f3ecc04 into traefik:master Mar 18, 2019
@ldez ldez changed the title (re)Add update ingress status Adds update ingress status Mar 18, 2019
@juliens juliens deleted the update-status branch September 6, 2019 05:39
@BretFisher BretFisher mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @geraldcroes @jbdoumenjou @ldez @traefiker