Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to go-acme/lego. #4589

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Migrate to go-acme/lego. #4589

merged 1 commit into from
Mar 14, 2019

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 14, 2019

What does this PR do?

Migrate to go-acme.

Fixed:

  • OVH: Refresh zone after deleting challenge record
  • hostingde: fix client fails if customer has no access to dns-groups
  • vscale: getting sub-domain
  • selectel: getting sub-domain
  • vscale: fix TXT records clean up
  • selectel: fix TXT records clean up

Motivation

Applies some bug fixes.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • Add DNS Provider for ClouDNS.net
  • Add DNS Provider for Oracle Cloud

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review area/acme bot/light-review decreases the number of required LGTM from 3 to 1. labels Mar 14, 2019
@ldez ldez added this to the next milestone Mar 14, 2019
juliens
juliens approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 87da752 into traefik:master Mar 14, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Mar 14, 2019
@ldez ldez deleted the feature/migrate-lego branch March 14, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @juliens @traefiker