Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go1.12. Support of TLS1.3 #4540

Merged
merged 4 commits into from
Mar 1, 2019
Merged

Update to Go1.12. Support of TLS1.3 #4540

merged 4 commits into from
Mar 1, 2019

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Feb 27, 2019 •
edited
Loading

What does this PR do?

Update to Go1.12.

Motivation

Be up-to-date.

Fix #4529, #4275, #4330

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: juliens julien@containo.us

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Feb 27, 2019
@ldez ldez added this to the next milestone Feb 27, 2019
@ldez ldez force-pushed the golang1.12 branch 5 times, most recently from 51e0a3b to a86fa7b Compare February 27, 2019 20:50
juliens
juliens approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

@traefiker traefiker merged commit fb61704 into traefik:master Mar 1, 2019
@ldez ldez deleted the golang1.12 branch March 1, 2019 10:59
@ldez ldez changed the title Update to Go1.12 Update to Go1.12. Support of TLS1.3 Mar 15, 2019
@ldez ldez mentioned this pull request Aug 14, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @geraldcroes @mmatur @traefiker