Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker node version #4448

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Update docker node version #4448

merged 1 commit into from
Jan 31, 2019

Conversation

Slashgear
Copy link
Contributor

What does this PR do?

  • Update webui docker image to Node Carbon (a compatible version of Node and with LTS until dec/2019)
  • Remove yarn JS package manager from image layers because it is now already installed in Node official image

Motivation

  • Maintain webui up to date 🎉

Additional Notes

@ldez ldez added this to the next milestone Jan 31, 2019
ldez
ldez approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋friend :)
LGTM!

@ldez ldez added the kind/enhancement a new or improved feature. label Jan 31, 2019
@ldez ldez mentioned this pull request Jan 31, 2019
Merged
juliens
juliens approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3008779 into traefik:master Jan 31, 2019
@ldez ldez changed the title chore(webui): update docker node version Update docker node version Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/webui kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Slashgear @juliens @ldez @emilevauge @traefiker