Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that test timeout service is ready. #4398

Merged

Conversation

timoreimann
Copy link
Contributor

@timoreimann timoreimann commented Jan 15, 2019

What does this PR do?

Check that the timeout service used in integration tests is ready prior to usage.

Motivation

We have observed flakiness in our local CI when the actual integration test executed already when the timeout service was still being bootstrapped. The PR unflaked things for us.

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This avoids flakiness where the timeout service might not be ready in
time.
@traefiker traefiker force-pushed the check-timeout-service-availability branch from e682317 to 19f60cb Compare January 16, 2019 13:44
@traefiker traefiker merged commit 8bb8ad5 into traefik:v1.7 Jan 16, 2019
@ldez ldez mentioned this pull request Jan 30, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants