Allow Træfik to update Ingress status #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
LGTM, thanks.
@containous/kubernetes @ldez I suppose this should go into a release branch, correct?
|
@rbq Thanks. Could you rebase on the v1.7 branch? @timoreimann yes 😉 |
geraldcroes
added
kind/enhancement
The example ClusterRole needs to updated for Træfik 1.7 to allow updating the status after successfully provisioning the Ingress. /closes traefik#3377 (cherry picked from commit 99fa7c7729c9e99545fb12f3cf80785a17096cdc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the manifest of the example ClusterRole for Træfik 1.7 and allows updating the status after successfully provisioning the Ingress. Fixes: #3377