Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forwarded headers on entry point configuration #4364

Merged
merged 5 commits into from
Jan 15, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 8, 2019

What does this PR do?

Add the forwarded header configuration and add the forwarded headers middleware.

Motivation

To reintegrate forwarded headers.

@nmengin nmengin added the kind/enhancement a new or improved feature. label Jan 8, 2019
@juliens juliens force-pushed the feature/forwarded-headers branch from cfe3da2 to a19b99d Compare January 8, 2019 15:50
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

config/static/entrypoints.go Outdated Show resolved Hide resolved
middlewares/forwardedheaders/forwarded_header.go Outdated Show resolved Hide resolved
middlewares/forwardedheaders/forwarded_header.go Outdated Show resolved Hide resolved
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens and others added 5 commits January 15, 2019 08:32
Co-authored-by: Gérald Croës <gerald@containo.us>
Co-Authored-By: juliens <julien.salleyron@gmail.com>
Co-Authored-By: juliens <julien.salleyron@gmail.com>
@traefiker traefiker force-pushed the feature/forwarded-headers branch from 1a4de25 to 0a0cbfd Compare January 15, 2019 08:32
@traefiker traefiker merged commit a79d6aa into traefik:master Jan 15, 2019
@juliens juliens deleted the feature/forwarded-headers branch September 6, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants