Retry middleware : store headers per attempts and propagate them when responding. #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
jlevesy
force-pushed
the
fix-stickiness-with-retry
branch
from
91ecce5 to
b5aa8f4
Compare
The retry middleware was loosing headers written before the request was sent to the backend. To fix that, we make the retryResponseWithouCloseNotify carry a header map which represent the headers gathered for the attempt. Then we write the attempt headers if only we're responding.
traefiker
force-pushed
the
fix-stickiness-with-retry
branch
from
b5aa8f4 to
46e9abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the
retryResponseWriterstore headers written during the attempt only write them when the attempt is successful.Fixes #3975
Motivation
The retry middleware was loosing response headers written before the request was actually sent to the backend.
This behaviour is caused by this line.
This is what was happening when sticking a request to a backend for instance (see here).
To fix that, we make the
retryResponseWritercarry a header map which represent theheaders gathered for the attempt. Then we propagate this header map to the response if only we decide to respond to the client.
More