Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rest provider #4253

Merged
merged 4 commits into from
Dec 3, 2018
Merged

Conversation

juliens
Copy link
Member

@juliens juliens commented Nov 29, 2018

What does this PR do?

Migrate rest provider to the new system

Motivation

Have one more provider migrated

More

  • Added/updated tests

juliens and others added 2 commits November 29, 2018 15:54
Co-authored-by: Gérald Croës <gerald@containo.us>
Co-authored-by: Gérald Croës <gerald@containo.us>
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration/resources/compose/rest.yml Outdated Show resolved Hide resolved
integration/rest_test.go Outdated Show resolved Hide resolved
provider/rest/rest.go Outdated Show resolved Hide resolved
provider/rest/rest.go Outdated Show resolved Hide resolved
provider/rest/rest.go Outdated Show resolved Hide resolved
integration/rest_test.go Outdated Show resolved Hide resolved
Co-Authored-By: juliens <julien.salleyron@gmail.com>
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c815a73 into traefik:master Dec 3, 2018
@ldez ldez deleted the migrate-rest-provider branch August 25, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants