Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Security Consideration" section in the Docker's backend section of the documentation #4225

Merged
merged 6 commits into from
Nov 27, 2018
Merged

Add a "Security Consideration" section in the Docker's backend section of the documentation #4225

merged 6 commits into from
Nov 27, 2018

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 23, 2018 •
edited
Loading

What does this PR do?

It adds a section "Security Consideration" in the Docker backend's configuration section, in the documentation.

Motivation

This new documentation section about Security relates to #4174 , to explains the risk and the ways to leverage or compensate.

It also provides a way to achieve Traefik container's scheduling on worker node with Swarm mode.

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

Nope

@dduportal dduportal requested a review from a team as a code owner November 23, 2018 19:10
@traefiker traefiker added this to the 1.7 milestone Nov 23, 2018
@dduportal dduportal requested review from emilevauge, ldez and geraldcroes and removed request for a team November 23, 2018 19:10
@dduportal dduportal mentioned this pull request Nov 23, 2018
Closed
ldez
ldez approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

vdemeester
vdemeester approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@dduportal @traefiker
Docs: add a section about docker security consideration with the socket
bd96d5e 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal @traefiker
Docs: markdown linting on config/backend/docker
91d20e3 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal @traefiker
Fixing multiple whitespaces
3dcb82e 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal @traefiker
Table layouts
7b8e112 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal @traefiker
Docs: more whitespaces
6f9a7dc 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal
Docs: inlining a citation and removing a single lost quote
4d9771d 
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@traefiker traefiker merged commit 7a93bcc into traefik:v1.7 Nov 27, 2018
@dduportal dduportal deleted the docs/GH-4174-docker-socket branch November 27, 2018 21:17
@ldez ldez mentioned this pull request Dec 4, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@vdemeester vdemeester vdemeester approved these changes

@emilevauge emilevauge Awaiting requested review from emilevauge

@geraldcroes geraldcroes Awaiting requested review from geraldcroes

Assignees
No one assigned
Labels
area/documentation area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@dduportal @vdemeester @ldez @dtomcej @traefiker