Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Rename "admin panel" to "dashboard #4156

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Documentation: Rename "admin panel" to "dashboard #4156

merged 1 commit into from
Nov 8, 2018

Conversation

thernstig
Copy link

@thernstig thernstig commented Nov 4, 2018

What does this PR do?

Fixes #4077, #4117

Motivation

To improve documentation for newcomers.

More

  • Added/updated documentation

@thernstig
Copy link
Author

@geraldcroes You can close #4117 as it seems inactive.

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the base branch from master to v1.7 November 5, 2018 15:43
@ldez ldez added this to the 1.7 milestone Nov 5, 2018
@ldez ldez removed the bot/no-merge label Nov 5, 2018
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@thernstig
Copy link
Author

@ldez Unsure of your way of working, but who merges this? :)

@ldez
Copy link
Contributor

ldez commented Nov 7, 2018

Our process is explained here:
/~https://github.com/containous/traefik/blob/master/MAINTAINER.md#pr-review-process

3 LGTM approvals by any maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants