Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing pass-client-tls annotation to the kubernetes provider #4118

Merged
merged 4 commits into from
Oct 29, 2018
Merged

Add the missing pass-client-tls annotation to the kubernetes provider #4118

merged 4 commits into from
Oct 29, 2018

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Add the pass-client-tls-cert annotation to the kubernetes provider.

Motivation

Fixes #4048
Related to #3826

More

  • Added/updated tests
  • Added/updated documentation

@jbdoumenjou jbdoumenjou requested a review from a team as a code owner October 26, 2018 13:36
@traefiker traefiker added this to the 1.7 milestone Oct 26, 2018
dtomcej
dtomcej approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

ldez
ldez approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou and others added 4 commits October 29, 2018 14:34
@jbdoumenjou @nmengin @traefiker
Add the pass-client-tls-cert annotation to the k8s provider
83d21b3 
Co-authored-by: Nicolas Mengin <nmengin.pro@gmail.com>
@jbdoumenjou @nmengin @traefiker
Add some tests
5cbcbdc 
Co-authored-by: Nicolas Mengin <nmengin.pro@gmail.com>
@jbdoumenjou @nmengin @traefiker
Add the documentation
9e8aab5 
Co-authored-by: Nicolas Mengin <nmengin.pro@gmail.com>
@jbdoumenjou @nmengin @traefiker
Add the generated file
5c0c396 
Co-authored-by: Nicolas Mengin <nmengin.pro@gmail.com>
@traefiker traefiker force-pushed the hotfix/GH-4048-passTLSClientCert-k8s-annotation branch from 37d8331 to 5c0c396 Compare October 29, 2018 14:34
@traefiker traefiker merged commit 450471d into traefik:v1.7 Oct 29, 2018
@traefiker traefiker mentioned this pull request Oct 29, 2018
Closed
@Oblynx

This comment has been minimized.

Sign in to view
@jbdoumenjou jbdoumenjou deleted the hotfix/GH-4048-passTLSClientCert-k8s-annotation branch November 21, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@jbdoumenjou @Oblynx @mmatur @ldez @dtomcej @traefiker