Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker backend] - Add config flag to set refreshSeconds for swarmmode ticker #4105

Merged
merged 3 commits into from
Nov 27, 2018
Merged

[docker backend] - Add config flag to set refreshSeconds for swarmmode ticker #4105

merged 3 commits into from
Nov 27, 2018

Conversation

WTFKr0
Copy link
Contributor

@WTFKr0 WTFKr0 commented Oct 24, 2018

What does this PR do?

This PR allow user to set a custom refresh interval for polling swarm mode socket for docker backend
The default value is 15
The new flag to set in config is --docker.refreshSeconds

@WTFKr0 WTFKr0 requested a review from a team as a code owner October 24, 2018 22:38
nmengin
nmengin approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @WTFKr0

Many thanks for this PR, only one comment.

provider/docker/docker.go Outdated Show resolved Hide resolved
nmengin
nmengin requested changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not choose the good status... Monday morning... 😉

SantoDE
SantoDE approved these changes Nov 12, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the change mentioned by @nmengin => LGTM 👼

nmengin
nmengin requested changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment @WTFKr0 ... 😄

cmd/configuration.go Outdated Show resolved Hide resolved
@ldez
Copy link
Contributor

ldez commented Nov 20, 2018

Could you rebase on v1.7?

WTFKr0 and others added 3 commits November 27, 2018 17:02
@WTFKr0 @mmatur
Add config flag to set refreshSeconds for swarmmode ticker
6327d6f 
Default to 15

Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
@WTFKr0 @mmatur
Rename RefreshSeconds => SwarmRefreshPeriod
e6bf024 
Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
@mmatur
fix: rename SwarmRefreshPeriod into SwarmModeRefreshSeconds+ add docu…
c3f4c79 
…mentation
@WTFKr0 WTFKr0 requested a review from a team as a code owner November 27, 2018 16:11
@mmatur mmatur changed the base branch from master to v1.7 November 27, 2018 16:11
@mmatur mmatur added this to the 1.7 milestone Nov 27, 2018
@mmatur mmatur removed the request for review from a team November 27, 2018 16:13
ldez
ldez approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9d26839 into traefik:v1.7 Nov 27, 2018
@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Nov 27, 2018

Thanx for taking this !

@WTFKr0 WTFKr0 deleted the docker-refreshseconds branch November 27, 2018 22:56
@ldez ldez mentioned this pull request Dec 4, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@SantoDE SantoDE SantoDE approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@WTFKr0 @ldez @SantoDE @nmengin @juliens @mmatur @traefiker