Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the trailing dot if the domain is not defined. #4095

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Remove the trailing dot if the domain is not defined. #4095

merged 2 commits into from
Oct 23, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 23, 2018 •
edited
Loading

What does this PR do?

Remove the trailing dot if the domain is not defined.

Motivation

Fix a bug

Seems related to #4011

More

  • Added/updated tests
  • [-] Added/updated documentation

Additional Notes

Thanks to @hsmade

Linked to #4086 and #4056

@traefiker traefiker added this to the 1.7 milestone Oct 23, 2018
@ldez ldez changed the title Consul Catalog frontend rule without domain Frontend rule without domain Oct 23, 2018
@ldez ldez requested review from a team as code owners October 23, 2018 09:55
@ldez ldez changed the title Frontend rule without domain Remove the trailing dot if the domain is not defined. Oct 23, 2018
@ldez ldez force-pushed the fix/cc-frontend-rule branch 2 times, most recently from d248efe to 4f5e4fa Compare October 23, 2018 10:28
SantoDE
SantoDE approved these changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

jbdoumenjou
jbdoumenjou approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed request for a team October 23, 2018 15:13
juliens
juliens approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/cc-frontend-rule branch from 4f5e4fa to 3238df1 Compare October 23, 2018 15:16
@traefiker traefiker merged commit c7df82e into traefik:v1.7 Oct 23, 2018
@ldez ldez deleted the fix/cc-frontend-rule branch October 23, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/consulcatalog area/provider/docker area/provider/ecs area/provider/marathon area/provider/mesos area/provider/rancher kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @jbdoumenjou @SantoDE @traefiker