Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update oxy #4009

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Fix update oxy #4009

merged 2 commits into from
Oct 10, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Oct 10, 2018

What does this PR do?

Update oxy:

  • Body should never be nil in buffer
  • Pass host header for Websocket

Motivation

Fixes #4005 #4006

@mmatur mmatur added status/2-needs-review kind/bug/fix a bug fix area/oxy bot/light-review decreases the number of required LGTM from 3 to 1. labels Oct 10, 2018
@mmatur mmatur added this to the 1.7 milestone Oct 10, 2018
@mmatur mmatur requested a review from ldez October 10, 2018 14:57
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants