Avoid a panic during Prometheus registering #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
status/2-needs-review
kind/bug/fix
nmengin
force-pushed
the
feature/remove-panic-prometheus-register
branch
from
ada1777 to
a809b60
Compare
nmengin
force-pushed
the
feature/remove-panic-prometheus-register
branch
from
47593f8 to
d611368
Compare
nmengin
force-pushed
the
feature/remove-panic-prometheus-register
branch
3 times, most recently
from
a486f4a to
858201c
Compare
traefiker
force-pushed
the
feature/remove-panic-prometheus-register
branch
from
858201c to
338fb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces the function which registers Træfik to Prometheus (which can generate
panic) by another one which never generatespanic.Motivation
Do not generate
panicand stop Træfik if it can not be registred to Prometheus (overkill?).More