Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete maintainers processes #3696

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Complete maintainers processes #3696

merged 2 commits into from
Jul 31, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jul 30, 2018

What does this PR do?

This PR updates the Contributions Daily Meeting section and updates labels list.

Motivation

Maintainers processes should be more detailed.

More

  • Added/updated documentation

WDYT @containous/traefik?
Anything to add/change?

@mmatur mmatur added this to the next milestone Jul 30, 2018
emilevauge
emilevauge approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New emergency approval clause works for me 👍

nmengin
nmengin approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1d53077 into traefik:master Jul 31, 2018
@mmatur mmatur deleted the feature/complete-maintainers-processes branch January 10, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mmatur @emilevauge @nmengin @dtomcej @traefiker