Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unrendered emoji #3690

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Replace unrendered emoji #3690

merged 1 commit into from
Jul 31, 2018

Conversation

korigod
Copy link
Contributor

@korigod korigod commented Jul 27, 2018

What does this PR do?

It replaces :heart: emoji with the corresponding Unicode emoji symbol: ❤️ — red heart emoji, U+2764+U+FE0F.

Motivation

MkDocs does not render :emoji:. The line looks like

Packaged as a single binary file (made with :hеart: with go) and available as a tiny official docker image

@mmatur mmatur changed the base branch from master to v1.7 July 30, 2018 15:55
@mmatur mmatur added this to the 1.7 milestone Jul 30, 2018
@mmatur mmatur changed the title docs: replace unrendered emoji Replace unrendered emoji Jul 31, 2018
juliens
juliens approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduportal
Copy link
Contributor

Looks Good To Me :)

vdemeester
vdemeester approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😍

@korigod @traefiker
docs: replace unrendered emoji
8e049d5 
MkDocs does not render :emoji: so it's replaced with the corresponding
Unicode emoji.
@traefiker traefiker merged commit eea60b6 into traefik:v1.7 Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@korigod @dduportal @vdemeester @juliens @mmatur @nmengin @traefiker