Adding compatibility for marathon 1.5 #3505
Conversation
ldez
added
kind/enhancement
|
@containous/marathon WDYT ? |
|
Looks reasonable, but we should test it against both Marathon 1.5 and <1.5 -- ideally by having a dedicated integration test. |
|
Working on trying to get integration tests, but getting the containers to play nice since Marathon 1.5 increased the mesos version requirements is being a bit more painful that I expected. For documentation, is there anything I need to add? Not sure whether there was anything around the fact that only Marathon <=1.4 is supported. |
I think the most important aspect we should check is whether there are any Marathon-specific parameters for which the behavior has changed with 1.5. Specifically, I'm wondering about Would you mind going over the Marathon backend documentation and the Marathon user guide and verify if anything might not be correct with 1.5 anymore? |
|
The only non-passive change that I know of was around networking related structures. I went over all the documentation and didn't notice anything that should be broken with 1.5 other than routing information. |
integration/marathon_test.go
Outdated
| @@ -138,3 +138,51 @@ func (s *MarathonSuite) TestConfigurationUpdate(c *check.C) { | |||
| err = try.GetRequest("http://127.0.0.1:8000/app", 30*time.Second, try.StatusCodeIs(http.StatusOK)) | |||
| c.Assert(err, checker.IsNil) | |||
| } | |||
|
|
|||
| // func (s *MarathonSuite) TestHostNetwork(c *check.C) { | |||
There was a problem hiding this comment.
Could you remove this method or uncomment it?
What does this PR do?
Committing changes we made in our private repo to support Marathon 1.5 in Traefik.
We have been using this with marathon 1.5 for since Traefik 1.5 (this also supports Marathon 1.4).
I have not been able to test that the backwards compatibility since we rebased these changes with 1.6 of Traefik.
Updating go-marathon is a requirement for this.
Motivation
Fixes #2115
More