Support 3xx HTTP status codes for health check #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/1-needs-design-review
area/healthcheck
kind/enhancement
|
Hello @SniperCZE Other proxies such as nginx only use 200-399 for response range. If you require the full range, can you link to the RFC you are referring to? We are wondering if the 1xx range should be included in this (being that they are information responses, usually used to confirm/upgrade connections). Would you be ok with just 200-399? |
ldez
changed the title
|
Hi @dtomcej I mean RFC 7231. There is section 6 about status codes and only 4xx and 5xx are labeled as error status. 1xx are informational - used ie. for upgrade http -> websockets. On the other hand, 1xx status codes are quite rare (in terms of loadbalancer healthcheck URLs) so probably 200 - 399 will be OK. |
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows all 3xx HTTP status codes (based on RFC) to pass healthcheck.
Motivation
PR #3362 adds only support for 2xx HTTP status codes, but according to RFC, 3xx are valid answers too and should not make server pushed out of pool, so this improve fix of #3081.
More