Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI typo into the buffering section. #3363

Merged
merged 3 commits into from
May 22, 2018
Merged

WebUI typo into the buffering section. #3363

merged 3 commits into from
May 22, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 21, 2018 •
edited
Loading

What does this PR do?

  • WebUI typo into the buffering section.
  • format large value into bar graph. (ex: 100k, 100M, ...)

Motivation

Fix typo.

Thanks to @Ch1ch1

@traefiker traefiker added this to the 1.6 milestone May 21, 2018
Ch1ch1
Ch1ch1 approved these changes May 22, 2018
View reviewed changes
Copy link

@Ch1ch1 Ch1ch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/webui-buffering branch from b92539f to d45fbdc Compare May 22, 2018 07:24
@traefiker traefiker force-pushed the fix/webui-buffering branch from d45fbdc to bfb66de Compare May 22, 2018 10:04
@traefiker traefiker merged commit 1cc1a4e into traefik:v1.6 May 22, 2018
@ldez ldez deleted the fix/webui-buffering branch May 22, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch1ch1 Ch1ch1 Ch1ch1 approved these changes

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/webui kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@ldez @juliens @mmatur @nmengin @Ch1ch1 @traefiker