Force to use ACME v02 endpoint. #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
refactor/force-acme-v02
branch
from
731c084 to
b64c600
Compare
dtomcej
suggested changes
May 21, 2018
configuration/configuration.go
Outdated
|
|
||
| if strings.Contains(gc.ACME.CAServer, "v01") { | ||
| caServer := strings.Replace(gc.ACME.CAServer, "v01", "v02", 1) | ||
| log.Warn("the CA server %q refer to a v01 endpoint of the ACME API, please change to %q.", gc.ACME.CAServer, caServer) |
There was a problem hiding this comment.
The log entry doesn't mention that you swapped v01 for v02. it is possible that for some reason, someone may want to use a CA server that contains v01 in the URL. I would test for a more exact match, or just warn in the logs.
nmengin
requested changes
May 22, 2018
configuration/configuration.go
Outdated
|
|
||
| if strings.HasPrefix(caServerSrc, "https://acme-v01.api.letsencrypt.org") { | ||
| caServer := strings.Replace(caServerSrc, "v01", "v02", 1) | ||
| log.Warnf("The CA server %q refer to a v01 endpoint of the ACME API, please change to %q.", caServerSrc, caServer) |
There was a problem hiding this comment.
s/refer/refers
No sure users will understand that a modification will be automatically done.
WDYT to use a more explicit message?
configuration/configuration.go
Outdated
| if strings.HasPrefix(caServerSrc, "https://acme-v01.api.letsencrypt.org") { | ||
| caServer := strings.Replace(caServerSrc, "v01", "v02", 1) | ||
| log.Warnf("The CA server %q refer to a v01 endpoint of the ACME API, please change to %q.", caServerSrc, caServer) | ||
| log.Warnf("ACME CA server fallback to %q.", caServer) |
There was a problem hiding this comment.
Why are you using 2 logs instructrions?
traefiker
force-pushed
the
refactor/force-acme-v02
branch
from
98270c8 to
e629222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Force to use ACME v02 endpoint: rewrite API URL if needed.
Motivation
Have a simple configuration.
Related to #3355