Update caServer to letsencrypt one in examples #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
status/2-needs-review
area/acme
and removed
status/0-needs-triage
labels
|
Please do not keep merging master into this branch. Our merge bot will take care of that for us. Re-merging master just takes cycles out of our CI. Thanks! |
|
@dtomcej understood |
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
As we are talking about letsencrypt since the begining of the doc, I would suggest to remove the private IPs from this example and replace them with the letsencrypt CA server one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update caServer field in the examples to put the staging endpoint of letsencrypt instead of private IPs
Motivation
As we are talking about letsencrypt since the beginning of the doc, I have the feeling that this will help avoid confusion.
More
Additional Notes