Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify some deprecations. #2959

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 2, 2018

What does this PR do?

Clarify the link between dnsProvider and dnsChallenge

Motivation

Can be confusing for some people.

More

  • Added/updated documentation

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

@traefiker traefiker force-pushed the refactor/doc-acme branch from b5b4b40 to f234c15 Compare March 2, 2018 13:26
@traefiker traefiker merged commit 13e2358 into traefik:v1.5 Mar 2, 2018
@ldez ldez deleted the refactor/doc-acme branch March 2, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants