Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dnsrr endpoint mode excluded when not using swarm LB #2795

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Fix dnsrr endpoint mode excluded when not using swarm LB #2795

merged 1 commit into from
Feb 5, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Feb 2, 2018

What does this PR do?

Fix an issue where Træfik stop exposing containers with endpoint_mode: dnsrr when label traefik.backend.loadbalancer.swarm=false

Motivation

Fixes #2793

More

  • Added/updated tests

@mmatur mmatur added this to the 1.5 milestone Feb 2, 2018
@mmatur mmatur requested a review from a team as a code owner February 2, 2018 16:23
@mmatur mmatur force-pushed the fix/docker-dnsrr branch 3 times, most recently from 79c6149 to b8488a0 Compare February 2, 2018 16:44
@ldez ldez added size/S and removed size/L labels Feb 2, 2018
ldez
ldez approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ce3a0fd into traefik:v1.5 Feb 5, 2018
@traefiker traefiker mentioned this pull request Feb 5, 2018
Closed
@mikeifomin
Copy link

Looking forward 1.5.2

@mmatur mmatur deleted the fix/docker-dnsrr branch March 21, 2018 17:47
@gozer gozer mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@mmatur @mikeifomin @juliens @ldez @nmengin @traefiker