-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar #2562
Grammar #2562
Conversation
docs/index.md
Outdated
@@ -22,7 +22,7 @@ If you want your users to access some of your microservices from the Internet, y | |||
- path `domain.com/web` will point the microservice `web` in your private network | |||
- domain `backoffice.domain.com` will point the microservices `backoffice` in your private network, load-balancing between your multiple instances | |||
|
|||
But a microservices architecture is dynamic... Services are added, removed, killed or upgraded often, eventually several times a day. | |||
But a microservices architecture is dynamic... Services are often added, removed, killed, or upgraded, eventually several times a day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the fault of this change, but I am not sure about this sentence at all...
But a microservices architecture is dynamic
Microservices or the architecture is not really the issue here, we are thinking about environments where instances of a service are launched dynamically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like:
But microservices architecture environments are dynamic: Services are often added,
removed, killed, or upgraded -- eventually several times a day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
Microservices are often deployed dynamic environments where services are added, removed, killed, upgraded or scaled many times a day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that there's a typo: deployed /in/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes minor grammar issues.