Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar #2562

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Grammar #2562

merged 2 commits into from
Dec 13, 2017

Conversation

geraldcroes
Copy link
Contributor

What does this PR do?

Fixes minor grammar issues.

docs/index.md Outdated
@@ -22,7 +22,7 @@ If you want your users to access some of your microservices from the Internet, y
- path `domain.com/web` will point the microservice `web` in your private network
- domain `backoffice.domain.com` will point the microservices `backoffice` in your private network, load-balancing between your multiple instances

But a microservices architecture is dynamic... Services are added, removed, killed or upgraded often, eventually several times a day.
But a microservices architecture is dynamic... Services are often added, removed, killed, or upgraded, eventually several times a day.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the fault of this change, but I am not sure about this sentence at all...

But a microservices architecture is dynamic

Microservices or the architecture is not really the issue here, we are thinking about environments where instances of a service are launched dynamically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

But microservices architecture environments are dynamic: Services are often added,
removed, killed, or upgraded -- eventually several times a day.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Microservices are often deployed dynamic environments where services are added, removed, killed, upgraded or scaled many times a day.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there's a typo: deployed /in/?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are correct

Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the base branch from master to v1.5 December 13, 2017 16:16
@ldez ldez added this to the 1.5 milestone Dec 13, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b6f5a66 into traefik:v1.5 Dec 13, 2017
@ldez ldez deleted the patch-3 branch August 2, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants